HyukjinKwon commented on a change in pull request #24182: [SPARK-27246][SQL]
Add an assert on invalid Scalar subquery plan with no column
URL: https://github.com/apache/spark/pull/24182#discussion_r268594770
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
##########
@@ -113,11 +113,6 @@ class AnalysisErrorSuite extends AnalysisTest {
(ScalarSubquery(testRelation.select('a, dateLit.as('b))) +
Literal(1)).as('a)),
"Scalar subquery must return only one column, but got 2" :: Nil)
- errorTest(
- "scalar subquery with no column",
- testRelation.select(ScalarSubquery(LocalRelation()).as('a)),
- "Scalar subquery must return only one column, but got 0" :: Nil)
Review comment:
Actually, I think this test update should be done in the other PR.
Technically, adding an assert doesn't cause any problem in this test for the
current status. Shall we just remove the test changes, and do it in the other
PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
