maryannxue commented on a change in pull request #24164: [SPARK-27225][SQL]
Implement join strategy hints
URL: https://github.com/apache/spark/pull/24164#discussion_r268818854
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -281,12 +346,6 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
// --- Without joining keys
------------------------------------------------------------
// Pick BroadcastNestedLoopJoin if one side could be broadcast
- case j @ logical.Join(left, right, joinType, condition, hint)
- if canBroadcastByHints(joinType, left, right, hint) =>
Review comment:
No, it is the same logic:
1) equi-join with "doable" broadcast hint -> broadcast-hash-join
2) equi-join without "doable" broadcast hint -> either shuffle-hash or smj
3) non-equi-join with "doable" broadcast hint -> broadcast-nested-loop join
4) non-equi-join without "doable" broadcast hint -> cartesian-product or
broadcast-nested-loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
