skonto commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance
spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r268835548
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -320,7 +336,8 @@ private[spark] class SparkSubmit extends Logging {
}
}
- args.sparkProperties.foreach { case (k, v) => sparkConf.set(k, v) }
+ // update spark config from args
+ args.toSparkConf(Option(sparkConf))
Review comment:
Need to keep this here as `args` are being updated within the body of this
method. We should clean it up in another PR. args should be immutable and we
should only modify SparkConf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
