zsxwing commented on a change in pull request #24186: [SPARK-27254][SS] Cleanup
complete but invalid output files in ManifestFileCommitProtocol if job is
aborted
URL: https://github.com/apache/spark/pull/24186#discussion_r268883336
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ManifestFileCommitProtocol.scala
##########
@@ -63,14 +65,32 @@ class ManifestFileCommitProtocol(jobId: String, path:
String)
if (fileLog.add(batchId, fileStatuses)) {
Review comment:
If this line fails after writing the content, abortJob will delete the
committed files. We should not remove files if this line is called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
