srowen commented on a change in pull request #24212: 
[SPARK-26771][SQL][FOLLOWUP] Make catalog table/view uncacheQuery non-blocking 
by default
URL: https://github.com/apache/spark/pull/24212#discussion_r268917335
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
 ##########
 @@ -365,7 +365,7 @@ class CatalogImpl(sparkSession: SparkSession) extends 
Catalog {
   override def dropTempView(viewName: String): Boolean = {
     sparkSession.sessionState.catalog.getTempView(viewName).exists { viewDef =>
       sparkSession.sharedState.cacheManager.uncacheQuery(
-        sparkSession, viewDef, cascade = false, blocking = true)
 
 Review comment:
   Let's just take out this argument, and ultimately make a non-blocking call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to