dilipbiswal commented on issue #24209: [SPARK-27255][SQL] Aggregate functions should not be allowed in WHERE URL: https://github.com/apache/spark/pull/24209#issuecomment-476475614 @cloud-fan Thanks for pointing me to this. I had seen it before but had completely forgotten about it :-). So Wenchen, in my understanding, this PR ensures that the integrity of the plan is not broken in the optimizer between application of rules. Is there something in specific you wanted me to focus on ? One thing i noticed is that here we reject plans which have aggregate expressions and plan node is not Aggregate. In this PR, we check for only Filter .. Did you want to target the fix to other operators as well just like the integrity check pr ? I feel its better to do check specific to problematic operators so we can issue targeted error message. What do you think ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
