gengliangwang commented on a change in pull request #24203: [SPARK-27269][SQL]
File source v2 should validate data schema only
URL: https://github.com/apache/spark/pull/24203#discussion_r268949009
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala
##########
@@ -37,22 +37,6 @@ abstract class FileScan(
false
}
- /**
- * Returns whether this format supports the given [[DataType]] in write path.
- * By default all data types are supported.
- */
- def supportsDataType(dataType: DataType): Boolean = true
-
- /**
- * The string that represents the format that this data source provider
uses. This is
- * overridden by children to provide a nice alias for the data source. For
example:
- *
- * {{{
- * override def formatName(): String = "ORC"
- * }}}
- */
- def formatName: String
-
Review comment:
The `formatName` was added for showing the Exception message.
https://github.com/apache/spark/pull/23714#pullrequestreview-203520602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
