dongjoon-hyun commented on a change in pull request #24203: [SPARK-27269][SQL]
File source v2 should validate data schema only
URL: https://github.com/apache/spark/pull/24203#discussion_r268951495
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileTable.scala
##########
@@ -46,17 +46,27 @@ abstract class FileTable(
sparkSession, rootPathsSpecified, caseSensitiveMap, userSpecifiedSchema,
fileStatusCache)
}
- lazy val dataSchema: StructType = userSpecifiedSchema.orElse {
- inferSchema(fileIndex.allFiles())
- }.getOrElse {
- throw new AnalysisException(
- s"Unable to infer schema for $name. It must be specified manually.")
- }.asNullable
+ lazy val dataSchema: StructType = userSpecifiedSchema.map { schema =>
+ val partitionSchema = fileIndex.partitionSchema
+ val equality = sparkSession.sessionState.conf.resolver
Review comment:
Do you mean the [one
line](https://github.com/apache/spark/blame/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala#L111)
written two year ago? All the other new instances use `resolver =
sparkSession.sessionState.conf.resolver` (more than 7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
