srowen commented on a change in pull request #24219: [SPARK-27258][K8S]Deal
with the Service name that does not match regular expression
^[a-z]([-a-z0-9]*[a-z0-9])?)
URL: https://github.com/apache/spark/pull/24219#discussion_r269176735
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
##########
@@ -198,5 +198,6 @@ private[spark] object KubernetesConf {
.replaceAll("\\.", "-")
.replaceAll("[^a-z0-9\\-]", "")
.replaceAll("-+", "-")
+ .replaceAll("^-", "")
Review comment:
Why? this character is allowed later in the name. I don't get why you can't
just check a-z? I don't think this PR is making progress, and will close it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
