cloud-fan commented on a change in pull request #24117: [SPARK-27181][SQL]: Add
public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r269260148
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -578,6 +578,21 @@ namedExpressionSeq
: namedExpression (',' namedExpression)*
;
+transformList
+ : '(' transforms+=transform (',' transforms+=transform)* ')'
+ ;
+
+transform
+ : qualifiedName
#identityTransform
+ | transformName=identifier
+ '(' argument+=transformArgument (',' argument+=transformArgument)* ')'
#applyTransform
+ ;
+
+transformArgument
+ : qualifiedName
+ | constant
Review comment:
I like the idea of keeping things simple, but do you think we will to
support `myFunc(a, 1 + 2)` in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
