MaxGekk commented on a change in pull request #24181: [SPARK-27242][SQL] Make
formatting TIMESTAMP/DATE literals independent from the default time zone
URL: https://github.com/apache/spark/pull/24181#discussion_r269265790
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -370,8 +371,11 @@ case class Literal (value: Any, dataType: DataType)
extends LeafExpression {
case _ => v + "D"
}
case (v: Decimal, t: DecimalType) => v + "BD"
- case (v: Int, DateType) => s"DATE '${DateTimeUtils.toJavaDate(v)}'"
- case (v: Long, TimestampType) =>
s"TIMESTAMP('${DateTimeUtils.toJavaTimestamp(v)}')"
+ case (v: Int, DateType) => s"DATE '${DateFormatter().format(v)}'"
Review comment:
We can do that but here we need `String`. Using `CAST` we will do
unnecessary conversion to `UTF8String`: `dateFormatter.format()` produces
`String` -> `UTF8String` -> and we will have to convert it back to `String`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
