cloud-fan commented on a change in pull request #24195: [SPARK-25496][SQL]
Deprecate from_utc_timestamp and to_utc_timestamp
URL: https://github.com/apache/spark/pull/24195#discussion_r269395838
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1231,6 +1238,11 @@ case class MonthsBetween(
case class ToUTCTimestamp(left: Expression, right: Expression)
extends BinaryExpression with ImplicitCastInputTypes {
+ if (!SQLConf.get.utcTimestampFuncEnabled) {
+ throw new AnalysisException(s"The $prettyName function has been disabled
since Spark 3.0. " +
+ s"Set ${SQLConf.UTC_TIMESTAMP_FUNC_ENABLED.key} to true to enable this
function.")
+ }
Review comment:
As I said, I don't think warning log is the right way to deprecate a SQL
function, as users won't see it. This is not good either but this is the best I
can think of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
