Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3022#issuecomment-67880399
@tgaloppo MLUtils.EPSILON is actually private[util]. I think it would be
fine to change it to be private[mllib]. CC: @mengxr
@tgaloppo I strongly recommend predict() instead of predictLabels() to be
consistent with KMeansModel.
@FlytxtRnD computeSoftAssignments() is a function of the model, not the
learning algorithm, so I think it belongs in the model. IMO, findClosest()
should be in KMeansModel instead of KMeans, but that should be fixed in another
PR. (It is not too important though since it is a private[mllib] API.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
