mgaido91 commented on a change in pull request #24223: [SPARK-27278][SQL]
Optimize GetMapValue when the map is a foldable and the key is not
URL: https://github.com/apache/spark/pull/24223#discussion_r269456325
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala
##########
@@ -59,6 +63,13 @@ object SimplifyExtractValueOps extends Rule[LogicalPlan] {
Literal(null, ga.dataType)
}
case GetMapValue(CreateMap(elems), key) => CaseKeyWhen(key, elems)
+ case GetMapValue(Literal(map: MapData, MapType(kt, vt, _)), key) =>
Review comment:
I don't think so. Constant folding is executed before this, hence if the key
is foldable we never get here. So the check is useless. We can add it and a
comment for explaining when this case happens if you think is needed, but it'd
be anyway quite clear from the history and the description of this PR...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
