wangyum commented on a change in pull request #23788: [SPARK-27176][SQL] 
Upgrade hadoop-3's built-in Hive maven dependencies to 2.3.4
URL: https://github.com/apache/spark/pull/23788#discussion_r269517199
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
 ##########
 @@ -336,8 +337,20 @@ private[hive] case class HiveUDAFFunction(
       funcWrapper.createFunction[AbstractGenericUDAFResolver]()
     }
 
-    val parameterInfo = new SimpleGenericUDAFParameterInfo(inputInspectors, 
false, false)
-    resolver.getEvaluator(parameterInfo)
+    val clazz = 
Utils.classForName(classOf[SimpleGenericUDAFParameterInfo].getName)
+    if (HiveUtils.isHive2) {
 
 Review comment:
   Hive 2.3.x([HIVE-13453](https://issues.apache.org/jira/browse/HIVE-13453)):
   ```val parameterInfo = new SimpleGenericUDAFParameterInfo(inputInspectors, 
false, false, false)```
   Hive 1.x:
   ```val parameterInfo = new SimpleGenericUDAFParameterInfo(inputInspectors, 
false, false)```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to