attilapiros commented on a change in pull request #24221: [SPARK-27248][SQL]
refresh table should recreate cache with same cache name
URL: https://github.com/apache/spark/pull/24221#discussion_r269681665
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -492,12 +492,19 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
// If this table is cached as an InMemoryRelation, drop the original
// cached version and make the new version cached lazily.
- if (isCached(table)) {
- // Uncache the logicalPlan.
+ val cache = sparkSession.sharedState.cacheManager.lookupCachedData(table)
+ if (cache.nonEmpty) {
+ // save the cache name and cache level for recreation
+ val cacheName = cache.get.cachedRepresentation.cacheBuilder.tableName
+ val cacheLevel = cache.get.cachedRepresentation.cacheBuilder.storageLevel
+
+ // uncache the logical plan.
sparkSession.sharedState.cacheManager.uncacheQuery(table, cascade = true)
- // Cache it again.
- sparkSession.sharedState.cacheManager.cacheQuery(table,
Some(tableIdent.table))
+
+ // recache with the same name.
+ sparkSession.sharedState.cacheManager.cacheQuery(table, cacheName,
cacheLevel)
}
+
Review comment:
Nit: remove unnecessary extra empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
