rdblue commented on a change in pull request #24117: [SPARK-27181][SQL]: Add
public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r269776790
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -578,6 +578,21 @@ namedExpressionSeq
: namedExpression (',' namedExpression)*
;
+transformList
+ : '(' transforms+=transform (',' transforms+=transform)* ')'
+ ;
+
+transform
+ : qualifiedName
#identityTransform
Review comment:
I think it is better to use `qualifiedName`. This may be a logical name in
the current use, but later Spark may need to resolve the transform using this
name. For example, this could be set to `builtin.bucket` to tell Spark that it
is the built-in bucket transform function. Using that information, Spark would
know it can run a bucketed join.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
