srowen commented on a change in pull request #24231: [minor] remove import
scala.collection.Set in TaskSchedulerImpl
URL: https://github.com/apache/spark/pull/24231#discussion_r269820493
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -829,7 +828,7 @@ private[spark] class TaskSchedulerImpl(
* Get a snapshot of the currently blacklisted nodes for the entire
application. This is
* thread-safe -- it can be called without a lock on the TaskScheduler.
*/
- def nodeBlacklist(): scala.collection.immutable.Set[String] = {
+ def nodeBlacklist(): Set[String] = {
blacklistTrackerOpt.map(_.nodeBlacklist()).getOrElse(scala.collection.immutable.Set())
Review comment:
You can change this line too. I agree, I don't see the reason to use a
mutable-or-immutable Set here. It's also used in getExecutorsAliveOnHost but
don't see why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
