srowen commented on a change in pull request #24223: [SPARK-27278][SQL]
Optimize GetMapValue when the map is a foldable and the key is not
URL: https://github.com/apache/spark/pull/24223#discussion_r269822485
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala
##########
@@ -59,6 +63,13 @@ object SimplifyExtractValueOps extends Rule[LogicalPlan] {
Literal(null, ga.dataType)
}
case GetMapValue(CreateMap(elems), key) => CaseKeyWhen(key, elems)
+ case GetMapValue(Literal(map: MapData, MapType(kt, vt, _)), key) =>
+ val elems = new mutable.ListBuffer[Literal]
+ map.foreach(kt, vt, (key, value) => {
Review comment:
Don't bother unless you're changing it otherwise, but `.foreach { case (kt,
vt, (key, value)) =>`?
Is the ListBuffer there for efficiency vs just flatMap-ing to two elements
for every map element?
```
val result = map.flatMap { case ((kt, vt, (key, value)) => Seq(Literal(key,
kt), Literal(value, vt)) }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
