beliefer commented on a change in pull request #24229: [SPARK-27275][CORE] Fix potential corruption in EncryptedMessage.transferTo (2.4) URL: https://github.com/apache/spark/pull/24229#discussion_r269842095
########## File path: common/network-common/src/main/java/org/apache/spark/network/crypto/TransportCipher.java ########## @@ -44,7 +44,8 @@ @VisibleForTesting static final String ENCRYPTION_HANDLER_NAME = "TransportEncryption"; private static final String DECRYPTION_HANDLER_NAME = "TransportDecryption"; - private static final int STREAM_BUFFER_SIZE = 1024 * 32; + @VisibleForTesting Review comment: I think `VisibleForTesting` annotation used for a member with modifier `final` is OK. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
