gaborgsomogyi commented on a change in pull request #19096: [SPARK-21869][SS] A
cached Kafka producer should not be closed if any task is using it - adds inuse
tracking.
URL: https://github.com/apache/spark/pull/19096#discussion_r269994119
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSinkSuite.scala
##########
@@ -418,17 +418,13 @@ class KafkaContinuousSinkSuite extends
KafkaContinuousTest {
val inputSchema = Seq(AttributeReference("value", BinaryType)())
val data = new Array[Byte](15000) // large value
val writeTask = new KafkaStreamDataWriter(Some(topic), options,
inputSchema)
- try {
- val fieldTypes: Array[DataType] = Array(BinaryType)
- val converter = UnsafeProjection.create(fieldTypes)
- val row = new SpecificInternalRow(fieldTypes)
- row.update(0, data)
- val iter = Seq.fill(1000)(converter.apply(row)).iterator
- iter.foreach(writeTask.write(_))
- writeTask.commit()
- } finally {
- writeTask.close()
- }
+ val fieldTypes: Array[DataType] = Array(BinaryType)
Review comment:
I meant the try block disappeared but you've reverted it so its fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
