hvanhovell commented on a change in pull request #24189:
[SPARK-27253][SQL]SparkSession clone discards SQLConf overrides in favor of
SparkConf defaults
URL: https://github.com/apache/spark/pull/24189#discussion_r270090840
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -86,7 +86,9 @@ abstract class BaseSessionStateBuilder(
*/
protected lazy val conf: SQLConf = {
val conf = parentState.map(_.conf.clone()).getOrElse(new SQLConf)
- mergeSparkConf(conf, session.sparkContext.conf)
+ if (parentState.isEmpty) {
Review comment:
We could tighten this up a bit, e.g.:
```scala
protected lazy val conf: SQLConf = {
parentState.map(_.conf.clone()).getOrElse {
val conf = new SQLConf
mergeSparkConf(conf, session.sparkContext.conf)
conf
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
