srowen commented on a change in pull request #23788: [SPARK-27176][SQL] Upgrade
hadoop-3's built-in Hive maven dependencies to 2.3.4
URL: https://github.com/apache/spark/pull/23788#discussion_r270106921
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
##########
@@ -54,8 +55,11 @@ private[spark] object HiveUtils extends Logging {
sc
}
+ private val hive1Version = "1.2.1"
+ private val hive2Version = "2.3.4"
+ val isHive2: Boolean = HiveVersionInfo.getVersion.equals(hive2Version)
Review comment:
OK, should this at least check for "isHive23" then and match on starting
with "2.3."? otherwise this may well work with 2.3.5 but will fail. What about
a future 2.4?
Can we ... drop Hive 1.2.x support entirely here or in a next PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
