gengliangwang commented on a change in pull request #24233: [SPARK-26356][SQL]
remove SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r270125233
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/noop/NoopDataSource.scala
##########
@@ -46,9 +45,7 @@ private[noop] object NoopTable extends Table with
SupportsWrite with SupportsStr
override def capabilities(): util.Set[TableCapability] =
Set(TableCapability.BATCH_WRITE).asJava
}
-private[noop] object NoopWriteBuilder extends WriteBuilder
- with SupportsSaveMode with SupportsTruncate {
- override def mode(mode: SaveMode): WriteBuilder = this
+private[noop] object NoopWriteBuilder extends WriteBuilder with
SupportsTruncate {
Review comment:
Since now DSV2(except file sources) can only write to an existing table,
here the write path of NoopDataSource will still fail (analyzer rule
`ResolveOutputRelation`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
