zsxwing commented on a change in pull request #24229: [SPARK-27275][CORE] Fix
potential corruption in EncryptedMessage.transferTo (2.4)
URL: https://github.com/apache/spark/pull/24229#discussion_r270135031
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/crypto/TransportCipher.java
##########
@@ -84,7 +85,8 @@ SecretKeySpec getKey() {
return outIv;
}
- private CryptoOutputStream createOutputStream(WritableByteChannel ch) throws
IOException {
+ @VisibleForTesting
Review comment:
This is package private. We usually use this to expose methods for junit.
It's not worth to encapsulate a class just for unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
