beliefer commented on issue #23841: [SPARK-26936][SQL] Fix bug of insert 
overwrite local dir can not create temporary path in local staging directory
URL: https://github.com/apache/spark/pull/23841#issuecomment-477856708
 
 
   > After the change, `qualifiedPath` is constructed as:
   > `val qualifiedPath = FileUtils.makeQualified(targetPath, hadoopConf)`
   > Before it was qualified w.r.t. the local file system.
   > Doesn't this become a path on the distributed file system? that's the 
point of this change. But, if `targetPath` is "/tmp/foo", this assumes it's 
valid to use "/tmp/foo" on the distributed storage. That doesn't seem 
technically right. Am I missing something so far?
   
   If `targetPath` is "/tmp/foo", and assumes it's valid to use `tmpPath` 
"hdfs://tmp/foo" on the distributed storage. 
   But the original code uses the "file:/tmp/foo" as `tmpPath`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to