Github user Earne commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r22201639
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -707,41 +710,38 @@ private[spark] class Master(
def rebuildSparkUI(app: ApplicationInfo): Boolean = {
val appName = app.desc.name
val notFoundBasePath = HistoryServer.UI_PATH_PREFIX + "/not-found"
- val eventLogDir = app.desc.eventLogDir.getOrElse {
+ val eventLogFile = app.desc.eventLogFile.getOrElse {
// Event logging is not enabled for this application
app.desc.appUiUrl = notFoundBasePath
return false
}
- val appEventLogDir = EventLoggingListener.getLogDirPath(eventLogDir,
app.id)
- val fileSystem = Utils.getHadoopFileSystem(appEventLogDir,
- SparkHadoopUtil.get.newConfiguration(conf))
- val eventLogInfo =
EventLoggingListener.parseLoggingInfo(appEventLogDir, fileSystem)
- val eventLogPaths = eventLogInfo.logPaths
- val compressionCodec = eventLogInfo.compressionCodec
-
- if (eventLogPaths.isEmpty) {
- // Event logging is enabled for this application, but no event logs
are found
- val title = s"Application history not found (${app.id})"
- var msg = s"No event logs found for application $appName in
$appEventLogDir."
- logWarning(msg)
- msg += " Did you specify the correct logging directory?"
- msg = URLEncoder.encode(msg, "UTF-8")
- app.desc.appUiUrl = notFoundBasePath + s"?msg=$msg&title=$title"
- return false
- }
-
try {
- val replayBus = new ReplayListenerBus(eventLogPaths, fileSystem,
compressionCodec)
+ val fs = Utils.getHadoopFileSystem(eventLogFile, hadoopConf)
+ val (logInput, sparkVersion) = EventLoggingListener.openEventLog(new
Path(eventLogFile), fs)
--- End diff --
@vanzin @andrewor14 can not see "Completed Applications" 's UI now. The
`eventLogFile` is still a base dir path like "hdfs://****/1.3.0/", may be we
still need EventLoggingListener.getLogPath(eventLogFile, app.id)?
*I think we should rename current eventLogFIle back to eventLogDir, and
make a new var eventLogFIle by using getLogPath
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
