gaborgsomogyi commented on issue #19096: [SPARK-21869][SS] A cached Kafka producer should not be closed if any task is using it - adds inuse tracking. URL: https://github.com/apache/spark/pull/19096#issuecomment-477952405 From direction perspective I think commons pool is a good choice in general. When I apply this to this specific case I'm not really sure about this for the following reasons: * The use-case is much more simple than the consumer side * Guava interface what we're using is thread-safe (the not thread-safe part in Spark code has no brain surgery complexity and don't foresee it will expand heavily) * Not sure if this sudden technology change would provide enough confidence for committers to merge it I would personally round-up this approach and change it only if committer explicitly request it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
