Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3638#issuecomment-67917707
Hi @mccheah @mingyukim,
Sorry for the late review. This fix looks good overall. I left a few
minor style comments. My main feedback is that I don't think that returning an
empty sequence in TaskSchedulerImpl is the right way to handle serialization
errors (see my diff comment); instead, I think we should skip over task sets
that fail and continue trying to schedule other task sets.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
