dongjoon-hyun commented on a change in pull request #24241:
[SPARK-27323][CORE][SQL][STREAMING] Use Single-Abstract-Method support in Scala
2.12 to simplify code
URL: https://github.com/apache/spark/pull/24241#discussion_r270643482
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -93,13 +93,7 @@ private[spark] class Executor(
val threadFactory = new ThreadFactoryBuilder()
.setDaemon(true)
.setNameFormat("Executor task launch worker-%d")
- .setThreadFactory(new ThreadFactory {
- override def newThread(r: Runnable): Thread =
- // Use UninterruptibleThread to run tasks so that we can allow
running codes without being
- // interrupted by `Thread.interrupt()`. Some issues, such as
KAFKA-1894, HADOOP-10622,
- // will hang forever if some methods are interrupted.
Review comment:
~Could you preserve this helpful comment?~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
