maropu commented on a change in pull request #24258:
[SPARK-27279][SQL][FOLLOW-UP] Reuse subquery should compare child plan of
`SubqueryExec`
URL: https://github.com/apache/spark/pull/24258#discussion_r270699427
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
##########
@@ -660,21 +660,28 @@ object CoalesceExec {
}
/**
- * Physical plan for a subquery.
+ * Parent class for different types of subquery plans
*/
-case class SubqueryExec(name: String, child: SparkPlan) extends UnaryExecNode {
-
- override lazy val metrics = Map(
- "dataSize" -> SQLMetrics.createSizeMetric(sparkContext, "data size"),
- "collectTime" -> SQLMetrics.createTimingMetric(sparkContext, "time to
collect"))
+abstract class BaseSubqueryExec extends SparkPlan {
+ def name: String
Review comment:
We need `name` in this base class for subquery exec?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
