ConeyLiu commented on a change in pull request #24237: [SPARK-27319][SQL]
Filter out dir based on PathFilter before listing them
URL: https://github.com/apache/spark/pull/24237#discussion_r270885096
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
##########
@@ -167,36 +167,39 @@ object InMemoryFileIndex extends Logging {
hadoopConf: Configuration,
filter: PathFilter,
sparkSession: SparkSession): Seq[(Path, Seq[FileStatus])] = {
+ // Filter out the directory before listing it leaf files
+ val filteredPaths = paths.filter(filter.accept(_))
// Short-circuits parallel listing when serial listing is likely to be
faster.
- if (paths.size <=
sparkSession.sessionState.conf.parallelPartitionDiscoveryThreshold) {
- return paths.map { path =>
+ if (filteredPaths.size <=
sparkSession.sessionState.conf.parallelPartitionDiscoveryThreshold) {
Review comment:
Hi @srowen, it's OK to filter the path in user code for me. However, it can
trigger a Spark job to filter the subdirectory when the directory need be
processed is really large by the current implementation. It would be very
slowly in user code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
