srowen commented on a change in pull request #24264: [SPARK-27216][CORE]
Upgrade RoaringBitmap to 0.7.45
URL: https://github.com/apache/spark/pull/24264#discussion_r270891744
##########
File path:
core/src/test/scala/org/apache/spark/serializer/UnsafeKryoSerializerSuite.scala
##########
@@ -32,4 +34,19 @@ class UnsafeKryoSerializerSuite extends KryoSerializerSuite
{
conf.set(KRYO_USE_UNSAFE, false)
super.afterAll()
}
+
+ test("SPARK-27216: Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe
ser/dser issue") {
+ val expected = new RoaringBitmap
+ expected.add(1787)
+
+ conf.set(KRYO_USE_UNSAFE, false)
+ val safeSer = new KryoSerializer(conf).newInstance()
+ var actual : RoaringBitmap =
safeSer.deserialize(safeSer.serialize(expected))
Review comment:
Nit: I think the style checker will flag the space before the colon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
