cloud-fan commented on a change in pull request #24253:
[SPARK-19712][SQL][FOLLOW-UP] Don't do partial pushdown when pushing down
LeftAnti joins below Aggregate or Window operators.
URL: https://github.com/apache/spark/pull/24253#discussion_r270893955
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushDownLeftSemiAntiJoin.scala
##########
@@ -70,10 +70,10 @@ object PushDownLeftSemiAntiJoin extends Rule[LogicalPlan]
with PredicateHelper {
}
// Check if the remaining predicates do not contain columns from the
right
- // hand side of the join. Since the remaining predicates will be kept
Review comment:
can we restore this comment now? I think the old version is pretty good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
