attilapiros commented on a change in pull request #24245:
[SPARK-13704][CORE][YARN] Reduce rack resolution time
URL: https://github.com/apache/spark/pull/24245#discussion_r271016523
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1631,7 +1635,14 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
}
val taskSet = FakeTask.createTaskSet(100, locations: _*)
val clock = new ManualClock
+ // make sure we only do one rack resolution call, for the entire batch of
hosts, as this
+ // can be expensive. the FakeTaskScheduler calls rack resolution more
than the real one
Review comment:
Nit: "expensive. the " => "expensive. The "
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
