zsxwing commented on a change in pull request #24140: [SPARK-27198][core]
Heartbeat interval mismatch in driver and executor
URL: https://github.com/apache/spark/pull/24140#discussion_r271067277
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -831,9 +832,11 @@ private[spark] class Executor(
}
val message = Heartbeat(executorId, accumUpdates.toArray,
env.blockManager.blockManagerId)
+ val heartbeatIntervalInSec =
+ conf.getTimeAsMs("spark.executor.heartbeatInterval",
"10s").millis.toSeconds.seconds
Review comment:
After discussing with @gatorsmile , we found there is a bug here. If
`spark.executor.heartbeatInterval` is less than one second, it will always be 0
and timeout.
(https://github.com/scala/scala/blob/v2.11.12/src/library/scala/concurrent/impl/Promise.scala#L209)
This may break some user's tests that set a small timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
