beliefer commented on issue #24265: [SPARK-27338][Core] Fix deadlock in UnsafeExternalSorter.SpillableIterator when locking both UnsafeExternalSorter.SpillableIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/24265#issuecomment-478821273 I checked the code and found `UnsafeExternalSorter.split` will call the `SpillableIterator.split`. `SpillableIterator.split` need to get lock on `UnsafeExternalSorter`. `UnsafeExternalSorter.loadNext` will call the `MemoryConsumer.freePage` and `MemoryConsumer.freePage` will call the `TaskMemoryManager.freePage`. `TaskMemoryManager.freePage` need to get lock on `TaskMemoryManager`. I think your PR seems good!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
