Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3707#discussion_r22232479
  
    --- Diff: docs/building-spark.md ---
    @@ -189,22 +200,22 @@ compilation. More advanced developers may wish to use 
SBT.
     The SBT build is derived from the Maven POM files, and so the same Maven 
profiles and variables
     can be set to control the SBT build. For example:
     
    -    sbt/sbt -Pyarn -Phadoop-2.3 assembly
    +    build/sbt -Pyarn -Phadoop-2.3 assembly
     
     # Testing with SBT
     
    -Some of the tests require Spark to be packaged first, so always run 
`sbt/sbt assembly` the first time.  The following is an example of a correct 
(build, test) sequence:
    +Some of the tests require Spark to be packaged first, so always run 
`build/sbt assembly` the first time.  The following is an example of a correct 
(build, test) sequence:
     
    -    sbt/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver assembly
    -    sbt/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver test
    +    build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver assembly
    +    build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver test
     
     To run only a specific test suite as follows:
     
    -    sbt/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver "test-only 
org.apache.spark.repl.ReplSuite"
    +    build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver "test-only 
org.apache.spark.repl.ReplSuite"
     
     To run test suites of a specific sub project as follows:
     
    -    sbt/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver core/test
    +    build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver core/test
     
     # Speeding up Compilation with Zinc
    --- End diff --
    
    Maybe we could mention `build/zinc` under this heading, and maybe mention 
something about how / when it's auto-started?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to