mgaido91 commented on a change in pull request #24209: [SPARK-27255][SQL]
Report error when illegal expressions are hosted by a plan operator.
URL: https://github.com/apache/spark/pull/24209#discussion_r271176610
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -376,6 +376,28 @@ trait CheckAnalysis extends PredicateHelper {
throw new IllegalStateException(
"Internal error: logical hint operator should have been removed
during analysis")
+ case f @ Filter(condition, _)
+ if PlanHelper.specialExpressionInUnsupportedOperator(f).nonEmpty =>
+ val invalidExprSqls =
PlanHelper.specialExpressionInUnsupportedOperator(f).map(_.sql)
+ failAnalysis(
+ s"""
+ |Aggregate/Window/Generate expressions are not valid in where
clause of the query.
+ |Expression in where clause: [${condition.sql}]
+ |Invalid expressions: [${invalidExprSqls.mkString(", ")}]
+ """.stripMargin)
+
+ case other if
PlanHelper.specialExpressionInUnsupportedOperator(other).nonEmpty =>
+ val invalidExprSqls =
+
PlanHelper.specialExpressionInUnsupportedOperator(other).map(_.sql)
+ failAnalysis(
+ s"""
+ |The query operator `${other.nodeName}` contains one or more
unsupported
+ |expression types Aggregate, Window or Generate.
+ |Invalid expressions: [${invalidExprSqls.mkString(", ")}]
+ |
Review comment:
nit: can we remove this line? and also close the string on the line above,
in order to avoid weird things like those `;` in the middle of nowhere in the
output
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
