Ngone51 commented on a change in pull request #24261: [SPARK-27192][Core]
spark.task.cpus should be less or equal than spark.executor.cores
URL: https://github.com/apache/spark/pull/24261#discussion_r271265061
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -577,16 +577,6 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
}
}
- if (contains(EXECUTOR_CORES) && contains(CPUS_PER_TASK)) {
- val executorCores = get(EXECUTOR_CORES)
- val taskCpus = get(CPUS_PER_TASK)
-
- if (executorCores < taskCpus) {
- throw new SparkException(
- s"${EXECUTOR_CORES.key} must not be less than ${CPUS_PER_TASK.key}.")
- }
- }
Review comment:
What's the difference between this and `checkCpusPerTask` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
