attilapiros commented on issue #24264: [SPARK-27216][CORE] Upgrade RoaringBitmap to 0.7.45 to fix Kryo unsafe ser/dser issue URL: https://github.com/apache/spark/pull/24264#issuecomment-478967540 @LantaoJin **Now your change is almost perfect.** But as there was no need to import `RoaringBitmap` for your test it made me think what kind of tests were here before your PR regarding this class. I have found this: https://github.com/apache/spark/blob/8cc3eb43b1b84822e51b536b4f220846c320786e/core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala#L373-L396 I think it is out-dated and this test can be removed as the statement `deserialize RoaringBitmap throw Buffer underflow exception` is false, what do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
