Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3651#issuecomment-68010880
Overall, this PR looks pretty good. To quickly summarize the changes
(mostly for my own benefit):
- Remove the `scalatest` and `scalatest-maven-plugin` dependencies from the
individual subproject POMs and add a `scalatest` dependency in the root POM
(since every subproject depends on it).
- Change every log4j.properties file to enable file appending instead of
overwriting.
Review comments:
- We should see whether we need to preserve the special configuration of
the ScalaTest Maven plugin in the `java8-tests` subproject.
- I like @vanzin's suggestion of adding a task that clears out the test
logs between runs.
- I also like the idea of using a common log4j.properties file across all
of the tests, but I'm fine with deferring that to a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
