Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3648#issuecomment-68011060
Actually, can you add a unit test for this? This change looks reasonable to
me but I am afraid that there is some corner case
For the unit test you can use create a new testsuite called
`ReceiverTrackerSuite` and start a context with a fake receiver (as in
`ReceiverSuite`) and then check the internal state of receiverInfo after
`context.start()` and after `context.stop()`. You could also use a
StreamingListener to count the number of times "RegisterReceiver" is received.
Also, could you add test for SPARK-4802 as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
