rxin commented on a change in pull request #24117: [SPARK-27181][SQL]: Add
public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r271505875
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -578,6 +578,21 @@ namedExpressionSeq
: namedExpression (',' namedExpression)*
;
+transformList
Review comment:
shouldn't the parser be generic, and we just throw errors on things that are
not supported? that'd give better error messages (typical technique used by
more mature databases) and also reduce the number of parsing rules in the
grammar file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
