cloud-fan commented on a change in pull request #24233: [SPARK-26356][SQL]
remove SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r271554103
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/noop/NoopSuite.scala
##########
@@ -54,7 +56,7 @@ class NoopSuite extends SharedSQLContext {
accum.add(1)
x
}
- .write.format("noop").save()
+ .write.format("noop").mode("append").save()
Review comment:
what if we end up with not changing the default mode (e.g. the community
doesn't agree with it)? do you think that's a blocker to forbid `ErrorIfExists`
and `Ignore` mode for `TableProvider`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
