attilapiros commented on a change in pull request #24270:
[SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10
URL: https://github.com/apache/spark/pull/24270#discussion_r271705900
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaProducer.scala
##########
@@ -37,9 +37,8 @@ private[kafka010] object CachedKafkaProducer extends Logging
{
private val defaultCacheExpireTimeout = TimeUnit.MINUTES.toMillis(10)
private lazy val cacheExpireTimeout: Long =
- Option(SparkEnv.get).map(_.conf.getTimeAsMs(
- "spark.kafka.producer.cache.timeout",
- s"${defaultCacheExpireTimeout}ms")).getOrElse(defaultCacheExpireTimeout)
+ Option(SparkEnv.get).map(_.conf.get(PRODUCER_CACHE_TIMEOUT)
+ ).getOrElse(defaultCacheExpireTimeout)
Review comment:
What I would do in this case is:
```scala
private lazy val cacheExpireTimeout: Long = Option(SparkEnv.get)
.map(_.conf.get(PRODUCER_CACHE_TIMEOUT))
.getOrElse(defaultCacheExpireTimeout)
```
Or simply write the whole expression into one line by renaming
`defaultCacheExpireTimeout` to something shorter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
