William1104 commented on issue #24221: [SPARK-27248][SQL] refresh table should 
recreate cache with same cache name
URL: https://github.com/apache/spark/pull/24221#issuecomment-479560769
 
 
   Hi @gatorsmile, thanks for the review. 
   
   * May I know where the migration guide? I am happy to update related 
session. 
   
   * A newly added test ‘Refresh Qualified Table’ would fail with the old 
behavior. The old behavior would recreate cache with unqualified name upon 
table refresh. This test was added to verify the new behavior. 
   
   * Yes. You are right that we should add a test to sql/core. I will checkout 
related test cases in sql/core to learn a bit more on that. 
   
   * it seems that we missed a test utility to create a cache with non temp 
table and clean them up afterward. I will creat such utility to enrich the test 
utilities. 
   
   * I will do my best to check those cache/uncache calls. Hope I did not miss 
anyone. 
   
   Again. Thanks for your help. 
   
   Best regards,
   William

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to