Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3710#discussion_r22243823
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -75,6 +78,11 @@ private[spark] class LiveListenerBus extends
SparkListenerBus with Logging {
}
def post(event: SparkListenerEvent) {
+ if (stopped) {
--- End diff --
Is there a cost to using volatile variables here? There are different
discussion around the web about the cost of the volatile being different for
different architectures, and since this can be a high volume bus, its probably
not a good idea to use a volatile variable. In fact it actually mixes two
different concurrency models (single-threaded actor, and threadsafe volatile)
which is usually not a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
