Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3761#discussion_r22244416
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ---
    @@ -278,7 +278,6 @@ private[hive] class SparkSQLCLIDriver extends CliDriver 
with Logging {
     
               ret = rc.getResponseCode
               if (ret != 0) {
    -            console.printError(rc.getErrorMessage())
    --- End diff --
    
    This line is not triggered because we didn't assign non-zero return code 
properly before. But now we're using proper return code. Although exceptions 
and error messages are also caught and reported in other places (e.g. within 
HiveContext), I still tend to keep this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to