gatorsmile commented on a change in pull request #24277: [SPARK-27349][SQL]
Dealing with TimeVars removed in Hive 2.x
URL: https://github.com/apache/spark/pull/24277#discussion_r271951721
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala
##########
@@ -61,4 +62,23 @@ class HiveUtilsSuite extends QueryTest with SQLTestUtils
with TestHiveSingleton
Thread.currentThread().setContextClassLoader(contextClassLoader)
}
}
+
+ test("SPARK-27349: Dealing with TimeVars removed in Hive 2.x") {
+ // Test default value
+ val defaultConf = new Configuration
+
assert(HiveUtils.formatTimeVarsForHiveClient(defaultConf)("hive.stats.jdbc.timeout")
=== "30")
+
assert(HiveUtils.formatTimeVarsForHiveClient(defaultConf)("hive.stats.retries.wait")
=== "3000")
+
+ def testFormatTimeVarsForHiveClient(key: String, value: String, expected:
Long): Unit = {
Review comment:
Move this out of the test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
